-
Notifications
You must be signed in to change notification settings - Fork 413
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Calculate text color of ConfusionMatrix plot based on luminance #2590
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
relativityhd
requested review from
SkafteNicki,
Borda,
justusschock and
stancld
as code owners
June 5, 2024 23:43
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2590 +/- ##
======================================
- Coverage 69% 69% -0%
======================================
Files 314 314
Lines 17702 17709 +7
======================================
+ Hits 12199 12200 +1
- Misses 5503 5509 +6 |
SkafteNicki
approved these changes
Jun 6, 2024
SkafteNicki
reviewed
Jun 6, 2024
auto-merge was automatically disabled
June 6, 2024 13:21
Head branch was pushed to by a user without write access
github-actions
bot
added
the
documentation
Improvements or additions to documentation
label
Jun 6, 2024
Borda
approved these changes
Jun 9, 2024
Borda
pushed a commit
that referenced
this pull request
Aug 2, 2024
* Calculate text color of ConfusionMatrix plot based on luminance * Update Changelog * Update plot_example image for Readme --------- Co-authored-by: Nicki Skafte Detlefsen <[email protected]> (cherry picked from commit 91b9e39)
Borda
pushed a commit
that referenced
this pull request
Aug 2, 2024
* Calculate text color of ConfusionMatrix plot based on luminance * Update Changelog * Update plot_example image for Readme --------- Co-authored-by: Nicki Skafte Detlefsen <[email protected]> (cherry picked from commit 91b9e39)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This will make the text-color of the ConfusionMatrix heatmap-plots white for darker-patches and white for brighter ones.
I haven't opened an Issue for this, since it is a non-intrusive and small change.
Before submitting
PR review
Assume the following Code:
Results now in the following plot:
This is how it looked before:
Did you have fun?
Make sure you had fun coding 🙃
📚 Documentation preview 📚: https://torchmetrics--2590.org.readthedocs.build/en/2590/