-
Notifications
You must be signed in to change notification settings - Fork 413
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix bootstrapper wrapper not being reset correctly #2574
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2574 +/- ##
========================================
- Coverage 69% 34% -34%
========================================
Files 314 314
Lines 17669 17673 +4
========================================
- Hits 12185 6096 -6089
- Misses 5484 11577 +6093 |
@SkafteNicki mind checking:
|
I assume it is due to the randomness in the bootstrapper. I try setting a seed in the docs and update the values |
I see, so we can seed the example... |
* fix + add to tests * changelog * update values --------- Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> Co-authored-by: Jirka Borovec <[email protected]> (cherry picked from commit cce449b)
* fix + add to tests * changelog * update values --------- Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> Co-authored-by: Jirka Borovec <[email protected]> (cherry picked from commit cce449b)
What does this PR do?
Fixes #2556
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃
📚 Documentation preview 📚: https://torchmetrics--2574.org.readthedocs.build/en/2574/