Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix documentation in ERGAS metric #2573

Merged
merged 2 commits into from
May 30, 2024
Merged

Fix documentation in ERGAS metric #2573

merged 2 commits into from
May 30, 2024

Conversation

SkafteNicki
Copy link
Member

@SkafteNicki SkafteNicki commented May 30, 2024

What does this PR do?

Fixes #2561

Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?
PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃


📚 Documentation preview 📚: https://torchmetrics--2573.org.readthedocs.build/en/2573/

@SkafteNicki SkafteNicki added the documentation Improvements or additions to documentation label May 30, 2024
@SkafteNicki SkafteNicki added this to the v1.3.x milestone May 30, 2024
@github-actions github-actions bot added topic: Image and removed documentation Improvements or additions to documentation labels May 30, 2024
Copy link

codecov bot commented May 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 38%. Comparing base (53fbadf) to head (5797aba).
Report is 99 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff            @@
##           master   #2573     +/-   ##
========================================
- Coverage      69%     38%    -31%     
========================================
  Files         314     314             
  Lines       17663   17663             
========================================
- Hits        12181    6691   -5490     
- Misses       5482   10972   +5490     

@mergify mergify bot added the ready label May 30, 2024
@Borda Borda merged commit 8ca1735 into master May 30, 2024
62 checks passed
@Borda Borda deleted the docs/ergas2 branch May 30, 2024 18:55
Borda pushed a commit that referenced this pull request Aug 2, 2024
(cherry picked from commit 8ca1735)
Borda pushed a commit that referenced this pull request Aug 2, 2024
(cherry picked from commit 8ca1735)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Documentation of ERGAS
2 participants