-
Notifications
You must be signed in to change notification settings - Fork 413
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add input_format
argument to segmentation metrics
#2572
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2572 +/- ##
========================================
- Coverage 69% 34% -35%
========================================
Files 314 314
Lines 17663 17669 +6
========================================
- Hits 12181 5937 -6244
- Misses 5482 11732 +6250 |
SkafteNicki
changed the title
add argument + change tests
Add May 30, 2024
input_format
argument to segmentation metrics
Borda
approved these changes
May 30, 2024
stancld
reviewed
May 30, 2024
stancld
reviewed
May 30, 2024
stancld
reviewed
May 30, 2024
stancld
reviewed
May 30, 2024
stancld
approved these changes
May 30, 2024
ok, I missed it for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #2563
I was foolish to think that the two formats supported in the new segmentation metrics could be differentiated on just based on the value of the tensors. My mistake. To fix this we need a explicit argument, but this opens up for supporting other input formats.
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃
📚 Documentation preview 📚: https://torchmetrics--2572.org.readthedocs.build/en/2572/