Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add input_format argument to segmentation metrics #2572

Merged
merged 5 commits into from
May 31, 2024

Conversation

SkafteNicki
Copy link
Member

@SkafteNicki SkafteNicki commented May 30, 2024

What does this PR do?

Fixes #2563
I was foolish to think that the two formats supported in the new segmentation metrics could be differentiated on just based on the value of the tensors. My mistake. To fix this we need a explicit argument, but this opens up for supporting other input formats.

Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?
PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃


📚 Documentation preview 📚: https://torchmetrics--2572.org.readthedocs.build/en/2572/

@SkafteNicki SkafteNicki added the bug / fix Something isn't working label May 30, 2024
@SkafteNicki SkafteNicki added this to the v1.3.x milestone May 30, 2024
Copy link

codecov bot commented May 30, 2024

Codecov Report

Attention: Patch coverage is 64.70588% with 6 lines in your changes missing coverage. Please review.

Project coverage is 34%. Comparing base (8ca1735) to head (c13055b).
Report is 98 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (8ca1735) and HEAD (c13055b). Click for more details.

HEAD has 76 uploads less than BASE
Flag BASE (8ca1735) HEAD (c13055b)
torch1.12.1+cpu 2 1
Linux 24 12
python3.9 16 8
cpu 39 20
Windows 6 3
python3.8 6 3
torch1.13.1+cpu 6 3
torch1.10.2+cpu 2 1
macOS 9 5
python3.10 9 5
torch2.0.1 3 2
torch1.11.0+cpu 2 1
torch2.3.0 2 1
python3.11 8 4
torch2.3.0+cpu 6 3
torch2.0.1+cpu 6 3
torch1.13.1 2 1
torch2.2.2+cpu 4 2
torch2.1.2+cpu 2 1
torch2.2.2 2 1
Additional details and impacted files
@@           Coverage Diff            @@
##           master   #2572     +/-   ##
========================================
- Coverage      69%     34%    -35%     
========================================
  Files         314     314             
  Lines       17663   17669      +6     
========================================
- Hits        12181    5937   -6244     
- Misses       5482   11732   +6250     

@SkafteNicki SkafteNicki changed the title add argument + change tests Add input_format argument to segmentation metrics May 30, 2024
@mergify mergify bot added the ready label May 30, 2024
@mergify mergify bot requested a review from a team May 30, 2024 19:31
@mergify mergify bot requested a review from a team May 30, 2024 19:32
@Borda Borda merged commit 744905c into master May 31, 2024
61 checks passed
@Borda Borda deleted the segmentation/add_input_format branch May 31, 2024 06:37
@Borda
Copy link
Member

Borda commented Sep 16, 2024

ok, I missed it for 1.4.2 but I believe can have 1.5.0 shortly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug / fix Something isn't working ready
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error for index tensor verification in GeneralizedDice if target is zeros
3 participants