fix unpredictable panoptic_quality output when return_per_class=True
#2548
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
i-aki-y
requested review from
SkafteNicki,
Borda,
justusschock and
stancld
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2548 +/- ##
========================================
- Coverage 69% 36% -33%
========================================
Files 314 314
Lines 17663 17663
========================================
- Hits 12179 6334 -5845
- Misses 5484 11329 +5845 |
|
Added changelog entry. |
SkafteNicki
approved these changes
May 30, 2024
Borda
pushed a commit
that referenced
this pull request
Aug 2, 2024
#2548) * fix panoptic_quality class order * added changelog and updated test-case --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Jirka Borovec <[email protected]> (cherry picked from commit 53fbadf)
Borda
pushed a commit
that referenced
this pull request
Aug 2, 2024
#2548) * fix panoptic_quality class order * added changelog and updated test-case --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Jirka Borovec <[email protected]> (cherry picked from commit 53fbadf)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fix #2547
PanopticQuality can return per class score when
return_per_class=Trueargument is given.But the order of the result is unpredictable.
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃
📚 Documentation preview 📚: https://torchmetrics--2548.org.readthedocs.build/en/2548/