Don't import pretty_errors

[kalekundert]

It's really inappropriate for a low-level library like this to be making global changes to the way stack traces are rendered. Especially since the "pretty" stack traces don't include file names or line numbers!

This is just crazy. All I wanted to do was import lightning, and I had to spend a couple hours tracking down why my stack traces were suddenly useless. If users want this behavior, they should knowingly opt-in themselves. They shouldn't be forced in by some dependency of a dependency of a dependency.

---

📚 Documentation preview 📚: https://torchmetrics--2543.org.readthedocs.build/en/2543/

[Borda]

Thank you for sharing your opinion; how/why do you install debug dependency in the first place? 🤔
ref: https://pypi.org/project/torchmetrics/1.4.0.post0 and #2527

[kalekundert]

I just installed lightning, yesterday:

$ python -m venv venv
$ . venv/bin/activate
$ pip install torchmetrics==1.4.0
...
$ pip freeze | grep pretty
pretty-errors==1.2.25

It's good that torchmetrics doesn't break stack traces by default as of 1.4.0.post0, but there's still no reason for this library to have the potential to do so. If a user want to use pretty_errors, they should modify site_customize.py or alias python, as recommended by pretty_errors itself.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69%. Comparing base (bfcd4b0) to head (1b3fe93).
Report is 102 commits behind head on master.

Additional details and impacted files

@@          Coverage Diff           @@
##           master   #2543   +/-   ##
======================================
  Coverage      69%     69%           
======================================
  Files         313     313           
  Lines       17617   17615    -2     
======================================
- Hits        12162   12161    -1     
+ Misses       5455    5454    -1