Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new Audio metric DNSMOS #2525

Merged
merged 106 commits into from
Jul 17, 2024
Merged

Add new Audio metric DNSMOS #2525

merged 106 commits into from
Jul 17, 2024

Conversation

quancs
Copy link
Member

@quancs quancs commented Apr 30, 2024

What does this PR do?

Add a new Audio metric DNSMOS

Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?
PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃


📚 Documentation preview 📚: https://torchmetrics--2525.org.readthedocs.build/en/2525/

@github-actions github-actions bot added documentation Improvements or additions to documentation topic: Audio labels Apr 30, 2024
@mergify mergify bot removed the ready label Jul 13, 2024
Copy link
Collaborator

@baskrahmer baskrahmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice addition! I enjoyed learning some more about audio metrics :)
I left some small formatting suggestions, but functionally everything is looking great.

src/torchmetrics/audio/dnsmos.py Outdated Show resolved Hide resolved
src/torchmetrics/audio/dnsmos.py Outdated Show resolved Hide resolved
src/torchmetrics/audio/dnsmos.py Outdated Show resolved Hide resolved
src/torchmetrics/audio/dnsmos.py Outdated Show resolved Hide resolved
src/torchmetrics/functional/audio/dnsmos.py Outdated Show resolved Hide resolved
tests/unittests/audio/test_dnsmos.py Show resolved Hide resolved
tests/unittests/audio/test_dnsmos.py Outdated Show resolved Hide resolved
tests/unittests/audio/test_dnsmos.py Outdated Show resolved Hide resolved
tests/unittests/audio/test_dnsmos.py Outdated Show resolved Hide resolved
tests/unittests/audio/test_dnsmos.py Outdated Show resolved Hide resolved
@mergify mergify bot added the ready label Jul 14, 2024
@quancs
Copy link
Member Author

quancs commented Jul 15, 2024

@Borda All tests passed

@quancs quancs requested review from baskrahmer and stancld July 15, 2024 12:03
@mergify mergify bot removed the has conflicts label Jul 17, 2024
@justusschock justusschock removed their assignment Jul 17, 2024
@Borda Borda enabled auto-merge (squash) July 17, 2024 09:52
@Borda Borda disabled auto-merge July 17, 2024 11:08
@Borda Borda merged commit 1ac0b63 into Lightning-AI:master Jul 17, 2024
65 of 71 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation ready topic: Audio
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants