Fix how auc scores are calculated in PrecisionRecallCurve.plot methods
#2437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SkafteNicki
requested review from
Borda,
justusschock and
stancld
as code owners
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #2437 +/- ##
======================================
Coverage 69% 69%
======================================
Files 307 307
Lines 17363 17363
======================================
Hits 11961 11961
Misses 5402 5402 |
Borda
approved these changes
Mar 7, 2024
justusschock
approved these changes
Mar 15, 2024
Borda
pushed a commit
that referenced
this pull request
Mar 16, 2024
…ods (#2437) Co-authored-by: Jirka Borovec <[email protected]> (cherry picked from commit 0a6ad01)
Borda
pushed a commit
that referenced
this pull request
Mar 18, 2024
…ods (#2437) Co-authored-by: Jirka Borovec <[email protected]> (cherry picked from commit 0a6ad01)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #2405
Because the scores for this metric is not in ascending order but descending the
directionargument should be set to-1.0when calculating the AUC. Additionally, adds a bit of description about how the value is calculated.Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃
📚 Documentation preview 📚: https://torchmetrics--2437.org.readthedocs.build/en/2437/