-
Notifications
You must be signed in to change notification settings - Fork 413
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Newmetric: Negative predictive value #2433
Conversation
for more information, see https://pre-commit.ci
…com/Lightning-AI/torchmetrics into newmetric/negative_predictive_value
d0a5568
to
9fc79ae
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your team's significant contribution to calculating negative predictive value (NPV) as a new classification metric. This work can reduce the computational burden on clinical doctors.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2433 +/- ##
========================================
- Coverage 69% 41% -28%
========================================
Files 328 344 +16
Lines 18525 18823 +298
========================================
- Hits 12737 7642 -5095
- Misses 5788 11181 +5393 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just a few nits on the docstrings
src/torchmetrics/functional/classification/negative_predictive_value.py
Outdated
Show resolved
Hide resolved
src/torchmetrics/functional/classification/negative_predictive_value.py
Outdated
Show resolved
Hide resolved
src/torchmetrics/functional/classification/negative_predictive_value.py
Outdated
Show resolved
Hide resolved
src/torchmetrics/functional/classification/negative_predictive_value.py
Outdated
Show resolved
Hide resolved
src/torchmetrics/functional/classification/negative_predictive_value.py
Outdated
Show resolved
Hide resolved
src/torchmetrics/functional/classification/negative_predictive_value.py
Outdated
Show resolved
Hide resolved
Co-authored-by: Luca Antiga <[email protected]>
What does this PR do?
Fixes #2415
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃
📚 Documentation preview 📚: https://torchmetrics--2433.org.readthedocs.build/en/2433/