Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Newmetric: Negative predictive value #2433

Merged
merged 26 commits into from
Oct 30, 2024
Merged

Conversation

SkafteNicki
Copy link
Member

@SkafteNicki SkafteNicki commented Mar 6, 2024

What does this PR do?

Fixes #2415

Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?
PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃


📚 Documentation preview 📚: https://torchmetrics--2433.org.readthedocs.build/en/2433/

@SkafteNicki SkafteNicki added enhancement New feature or request New metric labels Mar 6, 2024
@SkafteNicki SkafteNicki added this to the v1.4.0 milestone Mar 6, 2024
@github-actions github-actions bot added documentation Improvements or additions to documentation topic: Classif labels Mar 6, 2024
@Borda Borda force-pushed the master branch 2 times, most recently from d0a5568 to 9fc79ae Compare September 16, 2024 08:18
@SkafteNicki SkafteNicki modified the milestones: v1.4.0, v1.6.0 Oct 24, 2024
@SkafteNicki SkafteNicki self-assigned this Oct 24, 2024
@Borda Borda requested review from codyhesse and Asunatan October 25, 2024 07:52
Copy link

@Asunatan Asunatan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your team's significant contribution to calculating negative predictive value (NPV) as a new classification metric. This work can reduce the computational burden on clinical doctors.

Copy link

codecov bot commented Oct 25, 2024

Codecov Report

Attention: Patch coverage is 51.81818% with 53 lines in your changes missing coverage. Please review.

Project coverage is 41%. Comparing base (76c502b) to head (eda9e87).
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff            @@
##           master   #2433     +/-   ##
========================================
- Coverage      69%     41%    -28%     
========================================
  Files         328     344     +16     
  Lines       18525   18823    +298     
========================================
- Hits        12737    7642   -5095     
- Misses       5788   11181   +5393     

@SkafteNicki SkafteNicki marked this pull request as ready for review October 25, 2024 09:55
@mergify mergify bot added the ready label Oct 25, 2024
@Borda Borda requested a review from Asunatan October 29, 2024 10:55
Copy link
Contributor

@lantiga lantiga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a few nits on the docstrings

@mergify mergify bot removed the has conflicts label Oct 30, 2024
@Borda Borda enabled auto-merge (squash) October 30, 2024 20:39
@Borda Borda disabled auto-merge October 30, 2024 20:44
@Borda Borda merged commit 5d6bb56 into master Oct 30, 2024
45 of 50 checks passed
@Borda Borda deleted the newmetric/negative_predictive_value branch October 30, 2024 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request New metric ready topic: Classif
Projects
None yet
Development

Successfully merging this pull request may close these issues.

A new metric NPV
5 participants