experimenting with error improvements #2431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Borda
requested review from
SkafteNicki,
justusschock and
stancld
as code owners
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #2431 +/- ##
======================================
Coverage 69% 69%
======================================
Files 307 307
Lines 17410 17412 +2
======================================
+ Hits 11991 11993 +2
Misses 5419 5419 |
SkafteNicki
approved these changes
Mar 6, 2024
Borda
force-pushed
the
use-pretty_errors
branch
from
02de6c7 to
28978c8
Compare
Borda
force-pushed
the
use-pretty_errors
branch
from
bff1d98 to
791cf0d
Compare
matsumotosan
approved these changes
Apr 1, 2024
adamjstewart
reviewed
May 6, 2024
| @@ -6,3 +6,4 @@ packaging >17.1 | |||
| torch >=1.10.0, <2.3.0 | |||
| typing-extensions; python_version < '3.9' | |||
| lightning-utilities >=0.8.0, <0.12.0 | |||
| pretty-errors ==1.2.25 | |||
There was a problem hiding this comment.
Any chance we can relax this version constraint in the future?
adamjstewart
reviewed
May 6, 2024
| @@ -14,6 +14,9 @@ | |||
| _PACKAGE_ROOT = os.path.dirname(__file__) | |||
| _PROJECT_ROOT = os.path.dirname(_PACKAGE_ROOT) | |||
|
|
|||
| if package_available("pretty_errors"): | |||
| import pretty_errors # noqa: F401 | |||
There was a problem hiding this comment.
It seems like importing torchmetrics now has the effect of changing error messages for all other code. This seems undesirable. Couldn't this be left up to the user? Or the dependency made optional?
There was a problem hiding this comment.
Also seems unmaintained: onelivesleft/PrettyErrors#57
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
taking inspiration from https://bigl.es/tooling-tuesday-pretty-errors/ and https://towardsdatascience.com/one-line-of-code-to-say-goodbye-to-confusing-python-error-messages-8090ee6dd046
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃
📚 Documentation preview 📚: https://torchmetrics--2431.org.readthedocs.build/en/2431/