Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix plotting of metric collection when prefix/postfix is set #2429

Merged
merged 22 commits into from
Mar 15, 2024

Conversation

SkafteNicki
Copy link
Member

@SkafteNicki SkafteNicki commented Mar 5, 2024

What does this PR do?

Fixes #2411

Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?
PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃


📚 Documentation preview 📚: https://torchmetrics--2429.org.readthedocs.build/en/2429/

@SkafteNicki SkafteNicki added the bug / fix Something isn't working label Mar 5, 2024
@SkafteNicki SkafteNicki added this to the v1.3.x milestone Mar 5, 2024
Copy link

codecov bot commented Mar 5, 2024

Codecov Report

Merging #2429 (bef1d3d) into master (5980744) will not change coverage.
The diff coverage is 0%.

Additional details and impacted files
@@          Coverage Diff           @@
##           master   #2429   +/-   ##
======================================
  Coverage      69%     69%           
======================================
  Files         307     307           
  Lines       17357   17357           
======================================
  Hits        11957   11957           
  Misses       5400    5400           

@mergify mergify bot added the ready label Mar 6, 2024
@Borda Borda enabled auto-merge (squash) March 7, 2024 10:04
mergify bot and others added 12 commits March 13, 2024 14:13
…irements (#2445)

build(deps): update fire requirement in /requirements

Updates the requirements on [fire](https://github.com/google/python-fire) to permit the latest version.
- [Release notes](https://github.com/google/python-fire/releases)
- [Commits](google/python-fire@v0.1.0...v0.6.0)

---
updated-dependencies:
- dependency-name: fire
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…#2444)

Bumps [pytest-timeout](https://github.com/pytest-dev/pytest-timeout) from 2.2.0 to 2.3.1.
- [Commits](pytest-dev/pytest-timeout@2.2.0...2.3.1)

---
updated-dependencies:
- dependency-name: pytest-timeout
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@Borda Borda merged commit 0a82679 into master Mar 15, 2024
61 checks passed
@Borda Borda deleted the bugfix/plot_metriccollection branch March 15, 2024 16:59
Borda pushed a commit that referenced this pull request Mar 16, 2024
* implementation
* add tests
* changelog

(cherry picked from commit 0a82679)
Borda pushed a commit that referenced this pull request Mar 18, 2024
* implementation
* add tests
* changelog

(cherry picked from commit 0a82679)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug / fix Something isn't working ready
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to plot MetricCollection containing prefix using MetricCollection.plot()
4 participants