fix: MetricCollection did not copy the inner state of the metric in ClasswiseWrapper when computing group metrics
#2390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Wrapper when computing groups metrics Issue Link: Lightning-AI#2389
daniel-code
requested review from
SkafteNicki,
Borda,
justusschock and
stancld
as code owners
Borda
changed the title
MetricCollection did not copy the inner state of the metric in ClasswiseWrapper when computing group metrics
|
I find the The fix has been updated to the source branch. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #2390 +/- ##
========================================
- Coverage 69% 36% -33%
========================================
Files 307 307
Lines 17348 17363 +15
========================================
- Hits 11957 6218 -5739
- Misses 5391 11145 +5754 |
Borda
approved these changes
Feb 27, 2024
There was a problem hiding this comment.
Looks fine to me, @SkafteNicki @justusschock mind check pls 🐰
SkafteNicki
approved these changes
Mar 5, 2024
4 tasks
Borda
pushed a commit
that referenced
this pull request
Mar 16, 2024
… `ClasswiseWrapper` when computing group metrics (#2390) * fix: MetricCollection did not copy inner state of metric in ClasswiseWrapper when computing groups metrics Issue Link: #2389 * fix: set _persistent and _reductions be same as internal metric * test: check metric state_dict wrapped in `ClasswiseWrapper` --------- Co-authored-by: Jirka Borovec <[email protected]> (cherry picked from commit 1951a06)
Borda
pushed a commit
that referenced
this pull request
Mar 18, 2024
… `ClasswiseWrapper` when computing group metrics (#2390) * fix: MetricCollection did not copy inner state of metric in ClasswiseWrapper when computing groups metrics Issue Link: #2389 * fix: set _persistent and _reductions be same as internal metric * test: check metric state_dict wrapped in `ClasswiseWrapper` --------- Co-authored-by: Jirka Borovec <[email protected]> (cherry picked from commit 1951a06)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MetricCollection did not copy the inner state of the metric in ClasswiseWrapper when computing group metrics
Issue Link: #2389
What does this PR do?
Fixes #2389
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃
📚 Documentation preview 📚: https://torchmetrics--2390.org.readthedocs.build/en/2390/