Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: patch run with no tests #2362

Merged
merged 2 commits into from
Feb 9, 2024
Merged

ci: patch run with no tests #2362

merged 2 commits into from
Feb 9, 2024

Conversation

Borda
Copy link
Member

@Borda Borda commented Feb 7, 2024

What does this PR do?

Open #2345 revealed we had false positive failing cases when there were only docs changes

logging.debug("Only docs was changed so not reason for deep testing...")
return ""

The assistant for docs or other no-code changes returns an empty string, but that is interpreted by running all, including integrations which has missing requirements

Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?
PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃


📚 Documentation preview 📚: https://torchmetrics--2362.org.readthedocs.build/en/2362/

@Borda Borda added bug / fix Something isn't working test / CI testing or CI labels Feb 7, 2024
Copy link

codecov bot commented Feb 8, 2024

Codecov Report

Merging #2362 (0241315) into master (c0d2d3a) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files
@@          Coverage Diff           @@
##           master   #2362   +/-   ##
======================================
  Coverage      69%     69%           
======================================
  Files         305     305           
  Lines       17149   17149           
======================================
  Hits        11832   11832           
  Misses       5317    5317           

@Borda Borda enabled auto-merge (squash) February 8, 2024 09:01
@mergify mergify bot added the ready label Feb 9, 2024
@Borda Borda disabled auto-merge February 9, 2024 12:31
@Borda Borda merged commit 35bdeb6 into master Feb 9, 2024
59 checks passed
@Borda Borda deleted the ci/empty branch February 9, 2024 12:31
Borda added a commit that referenced this pull request Feb 12, 2024
(cherry picked from commit 35bdeb6)
Borda added a commit that referenced this pull request Feb 12, 2024
(cherry picked from commit 35bdeb6)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug / fix Something isn't working ready test / CI testing or CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants