-
Notifications
You must be signed in to change notification settings - Fork 413
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Memory optimization of perplexity metric #2346
Merged
Borda
merged 16 commits into
Lightning-AI:master
from
nsmlzl:fix/#2337_perplexity_mem_opt
Feb 8, 2024
Merged
Memory optimization of perplexity metric #2346
Borda
merged 16 commits into
Lightning-AI:master
from
nsmlzl:fix/#2337_perplexity_mem_opt
Feb 8, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nsmlzl
requested review from
SkafteNicki,
Borda,
justusschock and
stancld
as code owners
February 2, 2024 14:00
Borda
approved these changes
Feb 2, 2024
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #2346 +/- ##
========================================
- Coverage 69% 40% -29%
========================================
Files 305 305
Lines 17149 17149
========================================
- Hits 11832 6851 -4981
- Misses 5317 10298 +4981 |
SkafteNicki
approved these changes
Feb 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM :)
Borda
pushed a commit
that referenced
this pull request
Feb 12, 2024
* reduce memory footprint when computing perplexity (cherry picked from commit c0d2d3a)
Borda
pushed a commit
that referenced
this pull request
Feb 12, 2024
* reduce memory footprint when computing perplexity (cherry picked from commit c0d2d3a)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #2337 ; reduces the memory footprint when computing the perplexity by not creating a huge temporary tensor with n^2 elements (n: number of elements of target tensor) and subsequently only selecting the diagonal elements.
Instead, this change only computes the diagonal elements from the beginning (tensor with just n elements).
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃
📚 Documentation preview 📚: https://torchmetrics--2346.org.readthedocs.build/en/2346/