Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prefix postfix args in clone for multitask #2330

Merged
merged 7 commits into from
Feb 11, 2024
Merged

Conversation

SkafteNicki
Copy link
Member

@SkafteNicki SkafteNicki commented Jan 29, 2024

What does this PR do?

Fixes #2325
Nice to have feature. Similar to the way it is done in metric collection. These are the only two metrics that return dicts therefore it should not be necessary to add anywhere else.

Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?
PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃


📚 Documentation preview 📚: https://torchmetrics--2330.org.readthedocs.build/en/2330/

@SkafteNicki SkafteNicki added the enhancement New feature or request label Jan 29, 2024
@SkafteNicki SkafteNicki added this to the v1.4.0 milestone Jan 29, 2024
Copy link

codecov bot commented Jan 29, 2024

Codecov Report

Merging #2330 (e16feac) into master (35bdeb6) will decrease coverage by 34%.
Report is 1 commits behind head on master.
The diff coverage is 27%.

Additional details and impacted files
@@           Coverage Diff            @@
##           master   #2330     +/-   ##
========================================
- Coverage      69%     35%    -34%     
========================================
  Files         305     305             
  Lines       17149   17164     +15     
========================================
- Hits        11832    5982   -5850     
- Misses       5317   11182   +5865     

@mergify mergify bot added the ready label Feb 6, 2024
@Borda Borda enabled auto-merge (squash) February 7, 2024 23:37
@Borda Borda requested a review from a team February 7, 2024 23:37
@Borda Borda merged commit 4527aaf into master Feb 11, 2024
57 of 58 checks passed
@Borda Borda deleted the prefix_postfix_multitask branch February 11, 2024 02:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request ready
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can MultitaskWrapper.clone() have a postfix or prefix arg?
3 participants