Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New segmentation metric: Hausdorff Distance #2122

Merged
merged 44 commits into from
Oct 14, 2024
Merged

New segmentation metric: Hausdorff Distance #2122

merged 44 commits into from
Oct 14, 2024

Conversation

matsumotosan
Copy link
Member

@matsumotosan matsumotosan commented Oct 1, 2023 •
edited by github-actions bot
Loading

What does this PR do?

Fixes #1990

Before submitting
  • [x ] Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?
PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

📚 Documentation preview 📚: https://torchmetrics--2122.org.readthedocs.build/en/2122/

@Borda
Copy link
Member

Borda commented Dec 18, 2023

Seems like a big collision. Could you check it or maybe cherry-pick your commits on top of the master?

matsumotosan and others added 6 commits May 21, 2024 11:06
@matsumotosan @Borda
add docs
5ab879d
@matsumotosan @Borda
initial commit
b6519c3
@matsumotosan @Borda
fix hausdorff metric args
4f5d606
@matsumotosan @pre-commit-ci @Borda
ci: switch to custom docker images (Lightning-AI#2123)
80cbb1a 
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
@matsumotosan @Borda @pre-commit-ci
Add average to curve metrics (Lightning-AI#2084)
05c154a 
Co-authored-by: Jirka Borovec <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
@matsumotosan @Borda
symmetric test
ea58776
@Borda Borda force-pushed the 1990-hausdorff-distance branch from 3fc0d37 to ea58776 Compare May 21, 2024 09:19
@Borda
Copy link
Member

Borda commented Sep 23, 2024

@baskrahmer how is it going here? :)

@baskrahmer
Copy link
Collaborator

baskrahmer commented Sep 24, 2024 •
edited
Loading

@baskrahmer how is it going here? :)

@Borda there is an issue with the tests, related to running with DDP. Could you have a look?

@azure-pipelines Azure Pipelines
Copy link

There was an error handling pipeline event b3600a50-df3c-4a97-a1e3-4e33eb8eb07e.

@mergify mergify bot added the ready label Oct 14, 2024
@Borda Borda merged commit 1335c7b into Lightning-AI:master Oct 14, 2024
71 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SkafteNicki SkafteNicki SkafteNicki approved these changes

@Borda Borda Borda approved these changes

@lantiga lantiga Awaiting requested review from lantiga lantiga is a code owner

@justusschock justusschock Awaiting requested review from justusschock justusschock is a code owner

@stancld stancld Awaiting requested review from stancld stancld is a code owner

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation enhancement New feature or request New metric ready
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Hausdorff distance as a new classification metric
5 participants
@matsumotosan @Borda @Nachiket18 @baskrahmer @SkafteNicki