Skip to content

Helper functions for new segmentation domain #2105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 75 commits into from
Nov 30, 2023
Merged

Conversation

SkafteNicki
Copy link
Member

@SkafteNicki SkafteNicki commented Sep 23, 2023

What does this PR do?

This PR introduces a number of helper functions that will be beneficial for defining segmentation metrics.
In particular the two functions:

  • binary_erosion
  • distance_transform

are translated version of the corresponding functions from scipy.
We may need to change the utils in the future when we actually use them in metrics.

Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?
PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃


📚 Documentation preview 📚: https://torchmetrics--2105.org.readthedocs.build/en/2105/

@SkafteNicki SkafteNicki added the enhancement New feature or request label Sep 23, 2023
@SkafteNicki SkafteNicki added this to the v1.3.0 milestone Sep 23, 2023
@codecov
Copy link

codecov bot commented Sep 25, 2023

Codecov Report

Merging #2105 (081dae1) into master (b07b2a5) will decrease coverage by 54%.
Report is 1 commits behind head on master.
The diff coverage is 84%.

Additional details and impacted files
@@           Coverage Diff            @@
##           master   #2105     +/-   ##
========================================
- Coverage      87%     32%    -54%     
========================================
  Files         293     294      +1     
  Lines       16465   16627    +162     
========================================
- Hits        14300    5399   -8901     
- Misses       2165   11228   +9063     

@mergify mergify bot removed the ready label Nov 25, 2023
@mergify mergify bot added ready and removed ready labels Nov 25, 2023
@mergify mergify bot added the ready label Nov 25, 2023
@Borda Borda enabled auto-merge (squash) November 28, 2023 16:16
@Borda Borda merged commit 511b3fa into master Nov 30, 2023
@Borda Borda deleted the segmentation/helper branch November 30, 2023 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request ready
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants