Fix an inappropriate test expression to remove a logical short circuit #2082
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
munahaf
requested review from
SkafteNicki,
Borda,
justusschock and
stancld
as code owners
Borda
approved these changes
Sep 15, 2023
SkafteNicki
approved these changes
Sep 15, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #2082 +/- ##
========================================
- Coverage 87% 37% -49%
========================================
Files 287 287
Lines 16072 16072
========================================
- Hits 13964 6026 -7938
- Misses 2108 10046 +7938 |
matsumotosan
pushed a commit
to matsumotosan/metrics
that referenced
this pull request
Sep 17, 2023
Lightning-AI#2082) Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
matsumotosan
pushed a commit
to matsumotosan/metrics
that referenced
this pull request
Sep 19, 2023
Lightning-AI#2082) Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In file: _mean_ap.py, the comparison of Collection length creates a logical short circuit. I suggested that the Collection length comparison should be done without creating a logical short circuit.
Sponsorship and Support:
This work is done by the security researchers from OpenRefactory and is supported by the Open Source Security Foundation (OpenSSF): Project Alpha-Omega. Alpha-Omega is a project partnering with open source software project maintainers to systematically find new, as-yet-undiscovered vulnerabilities in open source code - and get them fixed – to improve global software supply chain security.
The bug is found by running the Intelligent Code Repair (iCR) tool by OpenRefactory and then manually triaging the results.
📚 Documentation preview 📚: https://torchmetrics--2082.org.readthedocs.build/en/2082/