-
Notifications
You must be signed in to change notification settings - Fork 413
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New metric: Davies bouldin score #2071
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SkafteNicki
requested review from
lantiga,
Borda,
justusschock and
stancld
as code owners
September 11, 2023 09:38
github-actions
bot
added
documentation
Improvements or additions to documentation
topic: Cluster
labels
Sep 11, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #2071 +/- ##
========================================
- Coverage 87% 36% -50%
========================================
Files 287 289 +2
Lines 16072 16128 +56
========================================
- Hits 13964 5874 -8090
- Misses 2108 10254 +8146 |
Borda
approved these changes
Sep 11, 2023
Borda
reviewed
Sep 11, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
btw, seems you are missing docs
justusschock
approved these changes
Sep 15, 2023
matsumotosan
added a commit
to matsumotosan/metrics
that referenced
this pull request
Sep 17, 2023
* implementation * fix error in other metric * links + init + utils * add tests * changelog * fix inf * changelog * docs
matsumotosan
pushed a commit
to matsumotosan/metrics
that referenced
this pull request
Sep 19, 2023
* implementation * fix error in other metric * links + init + utils * add tests * changelog * fix inf * changelog * docs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes part of #2003
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃
📚 Documentation preview 📚: https://torchmetrics--2071.org.readthedocs.build/en/2071/