-
Notifications
You must be signed in to change notification settings - Fork 423
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Metric: Dunn Index #2049
Merged
justusschock
merged 26 commits into
Lightning-AI:master
from
matsumotosan:2003-dunn-index
Sep 6, 2023
Merged
New Metric: Dunn Index #2049
justusschock
merged 26 commits into
Lightning-AI:master
from
matsumotosan:2003-dunn-index
Sep 6, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SkafteNicki
reviewed
Sep 4, 2023
Co-authored-by: Nicki Skafte Detlefsen <[email protected]>
Create inputs.py for clustering tests
* docs * functional * module * tests * changelog * try another link * mypy * remove broken link * change image * use new inputs * fix * fix flaky tests --------- Co-authored-by: Daniel Stancl <[email protected]> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
for more information, see https://pre-commit.ci
SkafteNicki
approved these changes
Sep 4, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #2049 +/- ##
======================================
Coverage 87% 87%
======================================
Files 281 283 +2
Lines 15886 15934 +48
======================================
+ Hits 13784 13832 +48
Misses 2102 2102 |
Borda
approved these changes
Sep 6, 2023
Co-authored-by: Jirka Borovec <[email protected]>
auto-merge was automatically disabled
September 6, 2023 12:53
Head branch was pushed to by a user without write access
Co-authored-by: Jirka Borovec <[email protected]>
for more information, see https://pre-commit.ci
justusschock
approved these changes
Sep 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes part of #2003
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃
📚 Documentation preview 📚: https://torchmetrics--2049.org.readthedocs.build/en/2049/