-
Notifications
You must be signed in to change notification settings - Fork 413
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improved the performance of RecallAtFixedPrecision for large batch sizes #2042
Conversation
for more information, see https://pre-commit.ci
@GlavitsBalazs nice, do you have a benchmark just to give an idea about the speedup? Also pls add entry in changelog |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #2042 +/- ##
========================================
- Coverage 87% 49% -38%
========================================
Files 279 279
Lines 15814 15828 +14
========================================
- Hits 13718 7743 -5975
- Misses 2096 8085 +5989 |
Ok. I've added the changelog entry. My issue submission contains some basic measurements illustrating the speedup. Please let me know if these aren't enough. I'll create more benchmarks if necessary. |
@GlavitsBalazs I think the tests you done are fine, I am reposting here for future reference:
|
Fixes mypy return-value error. Co-authored-by: Nicki Skafte Detlefsen <[email protected]>
Closes #2041 |
…zes (#2042) Co-authored-by: Nicki Skafte Detlefsen <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> (cherry picked from commit 694399a)
…zes (#2042) Co-authored-by: Nicki Skafte Detlefsen <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> (cherry picked from commit 694399a)
…zes (Lightning-AI#2042) Co-authored-by: Nicki Skafte Detlefsen <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
What does this PR do?
Addresses #2041.
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃
📚 Documentation preview 📚: https://torchmetrics--2042.org.readthedocs.build/en/2042/