-
Notifications
You must be signed in to change notification settings - Fork 413
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs on memory management #2006
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SkafteNicki
added
documentation
Improvements or additions to documentation
enhancement
New feature or request
labels
Aug 21, 2023
SkafteNicki
requested review from
lantiga,
Borda,
justusschock and
stancld
as code owners
August 21, 2023 07:50
Borda
approved these changes
Aug 21, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #2006 +/- ##
======================================
Coverage 87% 87%
======================================
Files 270 270
Lines 15581 15584 +3
======================================
+ Hits 13483 13486 +3
Misses 2098 2098 |
justusschock
approved these changes
Aug 21, 2023
stancld
reviewed
Aug 21, 2023
stancld
reviewed
Aug 21, 2023
stancld
reviewed
Aug 21, 2023
stancld
reviewed
Aug 21, 2023
stancld
reviewed
Aug 21, 2023
stancld
reviewed
Aug 21, 2023
stancld
approved these changes
Aug 21, 2023
Co-authored-by: Daniel Stancl <[email protected]>
Thanks for this @SkafteNicki ! |
matsumotosan
pushed a commit
to matsumotosan/metrics
that referenced
this pull request
Aug 25, 2023
Co-authored-by: Daniel Stancl <[email protected]> Co-authored-by: Jirka <[email protected]> Co-authored-by: Jirka Borovec <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #1949
Add a section about good memory management advice.
Also adds a new public attribute called
metric_state
such that users should be able to always investigate what is currently stored by the metric.Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃
📚 Documentation preview 📚: https://torchmetrics--2006.org.readthedocs.build/en/2006/