Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warning for CLIP Score on long captions #2001

Merged
merged 4 commits into from
Aug 19, 2023
Merged

Warning for CLIP Score on long captions #2001

merged 4 commits into from
Aug 19, 2023

Conversation

SkafteNicki
Copy link
Member

@SkafteNicki SkafteNicki commented Aug 16, 2023

What does this PR do?

Fixes #2000

Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?
PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃


📚 Documentation preview 📚: https://torchmetrics--2001.org.readthedocs.build/en/2001/

@SkafteNicki SkafteNicki added the enhancement New feature or request label Aug 16, 2023
@SkafteNicki SkafteNicki added this to the v1.1.0 milestone Aug 16, 2023
@codecov
Copy link

codecov bot commented Aug 16, 2023

Codecov Report

Merging #2001 (6832af1) into master (3b3b997) will decrease coverage by 52%.
The diff coverage is 17%.

Additional details and impacted files
@@           Coverage Diff            @@
##           master   #2001     +/-   ##
========================================
- Coverage      87%     34%    -52%     
========================================
  Files         268     268             
  Lines       15427   15433      +6     
========================================
- Hits        13360    5286   -8074     
- Misses       2067   10147   +8080     

@Borda Borda enabled auto-merge (squash) August 16, 2023 11:52
@mergify mergify bot added the ready label Aug 16, 2023
@Borda Borda requested a review from a team August 18, 2023 13:30
@Borda Borda merged commit 9fdd57c into master Aug 19, 2023
@Borda Borda deleted the feature/clip_warning branch August 19, 2023 09:22
matsumotosan pushed a commit to matsumotosan/metrics that referenced this pull request Aug 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request ready
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ClipScore errors on captions with more than 77 tokens
3 participants