Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Auroc metric when max_fpr is set and a class is missing #1895

Merged
merged 4 commits into from
Jul 11, 2023

Conversation

SkafteNicki
Copy link
Member

@SkafteNicki SkafteNicki commented Jul 9, 2023

What does this PR do?

Fixes #1891

Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?
PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃


📚 Documentation preview 📚: https://torchmetrics--1895.org.readthedocs.build/en/1895/

@SkafteNicki SkafteNicki added the bug / fix Something isn't working label Jul 9, 2023
@SkafteNicki SkafteNicki added this to the v1.1.0 milestone Jul 9, 2023
@SkafteNicki SkafteNicki requested a review from Borda as a code owner July 9, 2023 13:45
@codecov
Copy link

codecov bot commented Jul 9, 2023

Codecov Report

Merging #1895 (a1f8bd7) into master (5ac1290) will decrease coverage by 36%.
The diff coverage is 50%.

Additional details and impacted files
@@           Coverage Diff            @@
##           master   #1895     +/-   ##
========================================
- Coverage      85%     49%    -36%     
========================================
  Files         260     260             
  Lines       14912   14910      -2     
========================================
- Hits        12669    7251   -5418     
- Misses       2243    7659   +5416     

@mergify mergify bot added the ready label Jul 9, 2023
@Borda Borda modified the milestones: v1.1.0, v1.0.0, v1.0.x Jul 10, 2023
@Borda Borda requested a review from a team July 10, 2023 22:37
@justusschock justusschock merged commit 3fed40f into master Jul 11, 2023
@justusschock justusschock deleted the bugfix/auroc_max_fpr branch July 11, 2023 10:10
Borda pushed a commit that referenced this pull request Jul 12, 2023
Co-authored-by: Jirka Borovec <[email protected]>
Co-authored-by: Justus Schock <[email protected]>
(cherry picked from commit 3fed40f)
Borda pushed a commit that referenced this pull request Jul 13, 2023
Co-authored-by: Jirka Borovec <[email protected]>
Co-authored-by: Justus Schock <[email protected]>
(cherry picked from commit 3fed40f)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug / fix Something isn't working ready
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BinaryAUROC raises IndexError with max_fpr > 0 and only true edges
3 participants