-
Notifications
You must be signed in to change notification settings - Fork 423
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for PCC error with float16 tensor #1819
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we pls add test covering this case?
We do explicitly test that it does not work for float16: torchmetrics/tests/unittests/regression/test_pearson.py Lines 104 to 108 in 5a01f34
So just removing the xfail should be enough. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #1819 +/- ##
========================================
- Coverage 87% 41% -47%
========================================
Files 254 254
Lines 14303 14306 +3
========================================
- Hits 12510 5795 -6715
- Misses 1793 8511 +6718 |
What does this PR do?
Fixes #1813.
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃
📚 Documentation preview 📚: https://torchmetrics--1819.org.readthedocs.build/en/1819/