Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add C-SI-SNR #1785

Merged
merged 42 commits into from
May 22, 2023
Merged

add C-SI-SNR #1785

merged 42 commits into from
May 22, 2023

Conversation

quancs
Copy link
Member

@quancs quancs commented May 15, 2023

What does this PR do?

Add ComplexScaleInvariantSignalNoiseRatio metric for audio package.

Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?
PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃


📚 Documentation preview 📚: https://torchmetrics--1785.org.readthedocs.build/en/1785/

@quancs quancs marked this pull request as ready for review May 21, 2023 13:12
@Borda Borda enabled auto-merge (squash) May 21, 2023 13:23
@mergify mergify bot removed the ready label May 22, 2023
@mergify mergify bot removed the has conflicts label May 22, 2023
@SkafteNicki SkafteNicki added this to the v1.0.0 milestone May 22, 2023
@mergify mergify bot added the ready label May 22, 2023
@Borda Borda merged commit d4a3932 into Lightning-AI:master May 22, 2023
@quancs quancs deleted the c-si-snr branch May 23, 2023 02:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants