Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix corner case of calibration error #1648

Merged
merged 5 commits into from
Mar 28, 2023
Merged

Fix corner case of calibration error #1648

merged 5 commits into from
Mar 28, 2023

Conversation

SkafteNicki
Copy link
Member

What does this PR do?

Fixes #1646
Happens when a bin has zero confidence. Added code from issue as test.

Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?
PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@SkafteNicki SkafteNicki added the bug / fix Something isn't working label Mar 24, 2023
@SkafteNicki SkafteNicki added this to the v0.12 milestone Mar 24, 2023
@SkafteNicki SkafteNicki changed the title Fix cornor case of calibration error Fix corner case of calibration error Mar 24, 2023
@Borda Borda requested a review from a team March 24, 2023 08:52
@codecov
Copy link

codecov bot commented Mar 24, 2023

Codecov Report

Merging #1648 (f1a50a5) into master (685391d) will decrease coverage by 38%.
The diff coverage is 100%.

❗ Current head f1a50a5 differs from pull request most recent head eb9e1cc. Consider uploading reports for the commit eb9e1cc to get more accurate results

Additional details and impacted files
@@           Coverage Diff            @@
##           master   #1648     +/-   ##
========================================
- Coverage      89%     51%    -38%     
========================================
  Files         228     228             
  Lines       12363   12363             
========================================
- Hits        10945    6304   -4641     
- Misses       1418    6059   +4641     

@mergify mergify bot added the ready label Mar 24, 2023
@mergify mergify bot removed the has conflicts label Mar 28, 2023
@Borda Borda merged commit ae7a755 into master Mar 28, 2023
@Borda Borda deleted the bugfix/calibration_error branch March 28, 2023 10:11
@mergify mergify bot removed the ready label Mar 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug / fix Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

binary_calibration_error() throw RuntimeError when preds tensor contains some 0
3 participants