Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ruff: ANN - static annotations #1615

Merged
merged 8 commits into from
Mar 14, 2023
Merged

ruff: ANN - static annotations #1615

merged 8 commits into from
Mar 14, 2023

Conversation

Borda
Copy link
Member

@Borda Borda commented Mar 13, 2023

What does this PR do?

enable ruff static annotation check

Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?
PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@Borda Borda added the enhancement New feature or request label Mar 13, 2023
@Borda Borda requested a review from a team March 14, 2023 00:06
@Borda Borda enabled auto-merge (squash) March 14, 2023 07:11
@Borda Borda requested a review from tchaton as a code owner March 14, 2023 07:29
@codecov
Copy link

codecov bot commented Mar 14, 2023

Codecov Report

Merging #1615 (928b1ca) into master (087522b) will increase coverage by 0%.
The diff coverage is 100%.

Additional details and impacted files
@@          Coverage Diff           @@
##           master   #1615   +/-   ##
======================================
  Coverage      88%     88%           
======================================
  Files         226     226           
  Lines       12078   12089   +11     
======================================
+ Hits        10678   10689   +11     
  Misses       1400    1400           

@mergify mergify bot added the ready label Mar 14, 2023
@mergify mergify bot removed the has conflicts label Mar 14, 2023
@Borda Borda merged commit c8d649d into master Mar 14, 2023
@Borda Borda deleted the ruff/ANN branch March 14, 2023 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request ready
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants