-
Notifications
You must be signed in to change notification settings - Fork 413
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: explicit plot_options
& use super().plot(...)
#1565
Conversation
plot_options
& use super().plot(...)
`plot_options
& use super().plot(...)
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #1565 +/- ##
======================================
Coverage 88% 88%
======================================
Files 223 223
Lines 11672 11656 -16
======================================
- Hits 10322 10310 -12
+ Misses 1350 1346 -4 |
PR looks good to me, but after this PR #1485 was merged a few metrics are missing to be updated. |
I do not see any |
Here is an example: https://github.com/Lightning-AI/metrics/blob/df15e09e1a1581a737e0ef31b87adfbf84a1877b/src/torchmetrics/aggregation.py#L160-L201 |
ohh, I see it is different pattern, will add it :) |
What does this PR do?
This resolves typing issue as mypy can't trace the dict exxiciently, and also we have lots duplicated code so lets have it not implemented for remaining
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃