Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: explicit plot_options & use super().plot(...) #1565

Merged
merged 12 commits into from
Feb 28, 2023
Merged

Conversation

Borda
Copy link
Member

@Borda Borda commented Feb 27, 2023

What does this PR do?

This resolves typing issue as mypy can't trace the dict exxiciently, and also we have lots duplicated code so lets have it not implemented for remaining

Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?
PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@Borda Borda added this to the v0.12 milestone Feb 27, 2023
@Borda Borda changed the title refactor: explicit plot_options & use super().plot(...)` refactor: explicit plot_options & use super().plot(...) Feb 27, 2023
@Borda Borda requested a review from a team February 27, 2023 15:54
@Borda Borda added enhancement New feature or request refactoring refactoring and code health labels Feb 27, 2023
@codecov
Copy link

codecov bot commented Feb 27, 2023

Codecov Report

Merging #1565 (4d52e45) into master (704ddeb) will increase coverage by 0%.
The diff coverage is 98%.

Additional details and impacted files
@@          Coverage Diff           @@
##           master   #1565   +/-   ##
======================================
  Coverage      88%     88%           
======================================
  Files         223     223           
  Lines       11672   11656   -16     
======================================
- Hits        10322   10310   -12     
+ Misses       1350    1346    -4     

@Borda Borda enabled auto-merge (squash) February 27, 2023 17:49
@Borda Borda requested a review from ethanwharris February 28, 2023 08:19
@SkafteNicki
Copy link
Member

PR looks good to me, but after this PR #1485 was merged a few metrics are missing to be updated.

@Borda
Copy link
Member Author

Borda commented Feb 28, 2023

PR looks good to me, but after this PR #1485 was merged a few metrics are missing to be updated.

I do not see any plot_option as I did this last night so it shall be very aligned with latest set of master 🐿️

@SkafteNicki
Copy link
Member

PR looks good to me, but after this PR #1485 was merged a few metrics are missing to be updated.

I do not see any plot_option as I did this last night so it shall be very aligned with latest set of master 🐿️

Here is an example: https://github.com/Lightning-AI/metrics/blob/df15e09e1a1581a737e0ef31b87adfbf84a1877b/src/torchmetrics/aggregation.py#L160-L201

@Borda
Copy link
Member Author

Borda commented Feb 28, 2023

Here is an example:

ohh, I see it is different pattern, will add it :)

src/torchmetrics/metric.py Outdated Show resolved Hide resolved
@mergify mergify bot added the ready label Feb 28, 2023
@Borda Borda merged commit 0713dcb into master Feb 28, 2023
@Borda Borda deleted the refactor/plot branch February 28, 2023 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request ready refactoring refactoring and code health
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants