Add parameter top_k to RetrievalMAP
#1501
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e.g. MAP@10, i.e. consider only the top k elements for each query.
Bomme
requested review from
Borda,
SkafteNicki,
justusschock,
tchaton and
ethanwharris
as code owners
for more information, see https://pre-commit.ci
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #1501 +/- ##
========================================
- Coverage 88% 36% -53%
========================================
Files 216 216
Lines 11334 11344 +10
========================================
- Hits 10025 4047 -5978
- Misses 1309 7297 +5988 |
|
@lucadiliello please review :) |
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
lucadiliello
approved these changes
Feb 13, 2023
SkafteNicki
approved these changes
Feb 13, 2023
Borda
reviewed
Feb 13, 2023
Co-authored-by: Luca Di Liello <[email protected]>
Borda
approved these changes
Feb 13, 2023
Borda
changed the title
top_k to RetrievalMAP
Borda
reviewed
Feb 13, 2023
|
I will do a last review of the failing tests tomorrow before merging. |
|
Since we are left only with |
Borda
reviewed
Feb 23, 2023
Co-authored-by: Jirka Borovec <[email protected]>
@lucadiliello Feel free to do so :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #1491
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃