-
Notifications
You must be signed in to change notification settings - Fork 423
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Thiel's U Statistic (Uncertainty) Metric #1337
Conversation
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@stancld please re-review :] |
Co-authored-by: Nicki Skafte Detlefsen <[email protected]>
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #1337 +/- ##
========================================
- Coverage 87% 33% -53%
========================================
Files 208 210 +2
Lines 11695 11765 +70
========================================
- Hits 10134 3921 -6213
- Misses 1561 7844 +6283 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Very nice, thanks for the contribution!
Also, can we add a link for this metric to |
@stancld @SkafteNicki I was wondering why in each of these (
|
What does this PR do?
Implements
Theil's U
statistic for nominal (categorical) data.Fixes #1273
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃