Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename img metrics normalized #1293

Closed
wants to merge 3 commits into from
Closed

Rename img metrics normalized #1293

wants to merge 3 commits into from

Conversation

Borda
Copy link
Member

@Borda Borda commented Oct 25, 2022

What does this PR do?

addresses #1246 (comment)

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@Borda Borda added the refactoring refactoring and code health label Oct 25, 2022
@Borda Borda added this to the v0.11 milestone Oct 25, 2022
Copy link
Member

@justusschock justusschock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TBH, I'd prefer to keep it the current way. It is not a True/False in most of the cases but rather specifies which mechanism to use for normalization. In this context normalize as a verb makes more sense to me than an adjective (normalized). Also these changes would be breaking for no real reason.

@Borda
Copy link
Member Author

Borda commented Oct 26, 2022

In this context normalize as a verb makes more sense to me than an adjective (normalized)

for me, the normalize imply that the normalization will be done in the metric... 🐰

@mergify mergify bot added the has conflicts label Nov 3, 2022
@Borda Borda marked this pull request as draft November 3, 2022 22:20
@SkafteNicki
Copy link
Member

@Borda is this still needed?

@Borda
Copy link
Member Author

Borda commented Nov 9, 2022

@Borda is this still needed?

Was just writing the differences and realized that it is not... 🦦

@Borda Borda closed this Nov 9, 2022
@SkafteNicki SkafteNicki deleted the refactor/normalized branch May 10, 2023 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
has conflicts refactoring refactoring and code health
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants