-
Notifications
You must be signed in to change notification settings - Fork 413
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set minimum pytorch version to 1.8 + cleanup #1263
Conversation
#1259 has set |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #1263 +/- ##
======================================
- Coverage 86% 86% -0%
======================================
Files 195 195
Lines 11463 11388 -75
======================================
- Hits 9836 9762 -74
+ Misses 1627 1626 -1 |
seems like CI pulling the wrong version of torch for |
@SkafteNicki @Borda There's a
I guess this has to be updated |
seems like a bug in the assistant as it shall take the max |
@SkafteNicki seems there are a few tests failing for Windows and PT 1.8 |
What does this PR do?
Fixes #1262
Sets minimum pytorch version to 1.8 and clean-up all skipping/conditioning throughout the code that was necessary to run for older versions.
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃