-
Notifications
You must be signed in to change notification settings - Fork 413
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: (SSIM) propagate device if gaussian_kernel
is False, add test
#1149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krshrimali
requested review from
Borda,
SkafteNicki,
justusschock,
tchaton,
ethanwharris and
SeanNaren
as code owners
July 16, 2022 14:48
for more information, see https://pre-commit.ci
Codecov Report
@@ Coverage Diff @@
## master #1149 +/- ##
========================================
- Coverage 94% 42% -52%
========================================
Files 185 185
Lines 8389 8389
========================================
- Hits 7880 3539 -4341
- Misses 509 4850 +4341 |
Borda
approved these changes
Jul 18, 2022
justusschock
approved these changes
Jul 18, 2022
Co-authored-by: Justus Schock <[email protected]>
for more information, see https://pre-commit.ci
@justusschock any other alternative for |
for more information, see https://pre-commit.ci
Borda
pushed a commit
that referenced
this pull request
Jul 22, 2022
…1149) Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Jirka <[email protected]> (cherry picked from commit 45ac6b0)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Attempts to fix #1148 - summary of the changes:
device
,dtype
andchannel
are now propagated ifgaussian_kernel
isFalse
.Note to reviewers: I'm away from my GPU machine, so couldn't test this yet, I'll keep an eye on the CI, else I'll test it on my machine by tomorrow.(Tested on a GPU machine, all tests pass locally)Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃