Option to disable automatic syncronization #1107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SkafteNicki
requested review from
justusschock,
Borda,
tchaton,
ethanwharris and
SeanNaren
as code owners
Borda
approved these changes
Jun 28, 2022
stancld
approved these changes
Jun 29, 2022
Co-authored-by: Daniel Stancl <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #1107 +/- ##
======================================
- Coverage 94% 94% -0%
======================================
Files 180 180
Lines 8079 8082 +3
======================================
+ Hits 7594 7596 +2
- Misses 485 486 +1 |
Borda
pushed a commit
that referenced
this pull request
Jul 22, 2022
* sync option * changelog * more testing * fix missing arg (cherry picked from commit b49e579)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #1093
Adds
kwargsoption to disable automatic syncing whencomputeis called.Default is still
Truemeaning that we will auto sync on compute.Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃