-
Notifications
You must be signed in to change notification settings - Fork 415
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix wrong accumulation with average='none' #1046
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pls add the test mentioned in #1045
Codecov Report
@@ Coverage Diff @@
## master #1046 +/- ##
======================================
- Coverage 95% 95% -0%
======================================
Files 181 181
Lines 8004 8004
======================================
- Hits 7582 7581 -1
- Misses 422 423 +1 |
Hi @kpoeppel, |
@SkafteNicki : @Borda: |
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
What does this PR do?
Fixes #1045, simply copying tensors before they are mutated in-place.
Before submitting
-> Feel free to add the test mentioned in Accuracy, Precision, Recall, Specificity wrong accumulation with average='none' inside Wrapper. #1045
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃