-
Notifications
You must be signed in to change notification settings - Fork 423
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed default value for mdmc_average in Accuracy as per documentation #1036
Merged
Borda
merged 10 commits into
Lightning-AI:master
from
burglarhobbit:fix-default-value-typo-accuracy
May 26, 2022
Merged
Fixed default value for mdmc_average in Accuracy as per documentation #1036
Borda
merged 10 commits into
Lightning-AI:master
from
burglarhobbit:fix-default-value-typo-accuracy
May 26, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1036 +/- ##
======================================
- Coverage 95% 95% -0%
======================================
Files 181 181
Lines 8004 8004
======================================
- Hits 7582 7581 -1
- Misses 422 423 +1 |
@burglarhobbit thanks for this PR. It seems that you need to adjust some of these failing tests before we can merge this PR :) |
SkafteNicki
approved these changes
May 25, 2022
Borda
approved these changes
May 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR fixes the default value in argument for mdmc_average from
"global"
toNone
as per the documentation of Accuracy. This is also supported by the default value of mdmc_average in the documentation and code for F1Score, Precision and Recall.Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃