Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix nan in KL Divergence #1030

Merged
merged 10 commits into from
May 13, 2022
Merged

Fix nan in KL Divergence #1030

merged 10 commits into from
May 13, 2022

Conversation

SkafteNicki
Copy link
Member

@SkafteNicki SkafteNicki commented May 12, 2022

What does this PR do?

Fixes #1029

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@SkafteNicki SkafteNicki added the bug / fix Something isn't working label May 12, 2022
@SkafteNicki SkafteNicki added this to the v0.9 milestone May 12, 2022
@codecov
Copy link

codecov bot commented May 12, 2022

Codecov Report

Merging #1030 (89a114a) into master (2b382d0) will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff           @@
##           master   #1030   +/-   ##
======================================
  Coverage      95%     95%           
======================================
  Files         180     180           
  Lines        7828    7828           
======================================
  Hits         7435    7435           
  Misses        393     393           

@Borda Borda enabled auto-merge (squash) May 12, 2022 12:07
@mergify mergify bot added the ready label May 12, 2022
@mergify mergify bot removed the has conflicts label May 12, 2022
@mergify mergify bot removed the has conflicts label May 13, 2022
@Borda Borda merged commit bda65fe into master May 13, 2022
@Borda Borda deleted the bugfix/nan_in_kl_divergence branch May 13, 2022 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug / fix Something isn't working ready
Projects
None yet
Development

Successfully merging this pull request may close these issues.

KL-Divergence gives NaN on 0-probabilities
3 participants