Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix FID computation for non equal size #1028

Merged
merged 4 commits into from
May 12, 2022
Merged

Conversation

SkafteNicki
Copy link
Member

@SkafteNicki SkafteNicki commented May 11, 2022

What does this PR do?

Fixes #1027

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@SkafteNicki SkafteNicki added the bug / fix Something isn't working label May 11, 2022
@SkafteNicki SkafteNicki added this to the v0.9 milestone May 11, 2022
@codecov
Copy link

codecov bot commented May 11, 2022

Codecov Report

Merging #1028 (7e8ae8f) into master (6f5ac1e) will decrease coverage by 0%.
The diff coverage is 100%.

@@          Coverage Diff           @@
##           master   #1028   +/-   ##
======================================
- Coverage      95%     95%   -0%     
======================================
  Files         180     180           
  Lines        7823    7824    +1     
======================================
- Hits         7430    7419   -11     
- Misses        393     405   +12     

@Borda Borda enabled auto-merge (squash) May 12, 2022 11:11
@mergify mergify bot added the ready label May 12, 2022
@Borda Borda merged commit 6cffeb5 into master May 12, 2022
@Borda Borda deleted the bugfix/fid_non_equal_size branch May 12, 2022 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug / fix Something isn't working ready
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FrechetInceptionDistance wrong behavior for calculating two features with different batch size
3 participants