Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RichModelSummary callback #9546

Merged
merged 9 commits into from
Sep 17, 2021
Merged

Add RichModelSummary callback #9546

merged 9 commits into from
Sep 17, 2021

Conversation

kaushikb11
Copy link
Contributor

@kaushikb11 kaushikb11 commented Sep 15, 2021

What does this PR do?

Follow up to #8929

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@kaushikb11 kaushikb11 self-assigned this Sep 15, 2021
@kaushikb11 kaushikb11 added callback feature Is an improvement or enhancement labels Sep 15, 2021
@kaushikb11 kaushikb11 marked this pull request as ready for review September 15, 2021 19:24
@kaushikb11 kaushikb11 added this to the v1.5 milestone Sep 15, 2021
@codecov
Copy link

codecov bot commented Sep 16, 2021

Codecov Report

Merging #9546 (6dd81bc) into master (45200fc) will increase coverage by 0%.
The diff coverage is 96%.

❗ Current head 6dd81bc differs from pull request most recent head 17a3d76. Consider uploading reports for the commit 17a3d76 to get more accurate results

@@          Coverage Diff           @@
##           master   #9546   +/-   ##
======================================
  Coverage      93%     93%           
======================================
  Files         180     181    +1     
  Lines       15116   15159   +43     
======================================
+ Hits        14043   14084   +41     
- Misses       1073    1075    +2     

@mergify mergify bot added the ready PRs ready to be merged label Sep 17, 2021
@SeanNaren SeanNaren enabled auto-merge (squash) September 17, 2021 10:23
@SeanNaren SeanNaren merged commit 2ec39e2 into master Sep 17, 2021
@SeanNaren SeanNaren deleted the add/rich_model_summary branch September 17, 2021 10:54
SeanNaren pushed a commit that referenced this pull request Sep 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
callback feature Is an improvement or enhancement ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants