Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3/n Consolidate collective functions - Integrate with TrainingTypePlugin #9472

Closed
wants to merge 8 commits into from

Conversation

four4fish
Copy link
Contributor

@four4fish four4fish commented Sep 13, 2021

What does this PR do?

Implementing proposal here https://docs.google.com/document/d/1e83FcZHHHsTmiUmNpgmPTBYjugZaC3pcZhd4VV9AuIM/edit

Steps:

  1. [RFC] create pytorch_lightning/utilities/collective_util.py and move collective related utils from distributed.py to collective_util.py
  2. 2/n Consolidate collective functions - collective base and subclasses. (this PR)
  3. Integrate with all training_type_plugins (ddp, dp, fullshard and etc) and
  4. Integrate with Accelerators

Fixes #7534

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@ananthsub ananthsub changed the title 3/n Consolidate collective functions - Integrate with TTPs 3/n Consolidate collective functions - Integrate with TrainingTypePlugin Sep 14, 2021
@stale
Copy link

stale bot commented Sep 28, 2021

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. If you need further help see our docs: https://pytorch-lightning.readthedocs.io/en/latest/generated/CONTRIBUTING.html#pull-request or ask the assistance of a core contributor here or on Slack. Thank you for your contributions.

@stale stale bot added the won't fix This will not be worked on label Sep 28, 2021
@awaelchli awaelchli added design Includes a design discussion feature Is an improvement or enhancement and removed won't fix This will not be worked on labels Sep 28, 2021
@tchaton
Copy link
Contributor

tchaton commented Oct 12, 2021

Hey @four4fish,

What is the status on this PR ?

Best,
T.C

@four4fish
Copy link
Contributor Author

@tchaton this is pending on 2/n Consolidate collective functions - collective base and subclasses #9414. There are some open questions about the api design still in discussion
Collective refactor will not be included in 1.5 release.

@awaelchli awaelchli mentioned this pull request Oct 25, 2021
23 tasks
@stale
Copy link

stale bot commented Oct 28, 2021

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. If you need further help see our docs: https://pytorch-lightning.readthedocs.io/en/latest/generated/CONTRIBUTING.html#pull-request or ask the assistance of a core contributor here or on Slack. Thank you for your contributions.

@stale stale bot added the won't fix This will not be worked on label Oct 28, 2021
@carmocca carmocca removed the won't fix This will not be worked on label Oct 29, 2021
@tchaton tchaton added this to the v1.6 milestone Nov 1, 2021
@carmocca carmocca removed this from the 1.6 milestone Mar 28, 2022
@stale
Copy link

stale bot commented Apr 16, 2022

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. If you need further help see our docs: https://pytorch-lightning.readthedocs.io/en/latest/generated/CONTRIBUTING.html#pull-request or ask the assistance of a core contributor here or on Slack. Thank you for your contributions.

@stale stale bot added the won't fix This will not be worked on label Apr 16, 2022
@stale
Copy link

stale bot commented Apr 21, 2022

This pull request is going to be closed. Please feel free to reopen it create a new from the actual master.

@stale stale bot closed this Apr 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design Includes a design discussion feature Is an improvement or enhancement won't fix This will not be worked on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consolidate collective functions
4 participants