Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix restoring training state during trainer.fit only #9413

Merged
merged 34 commits into from
Oct 6, 2021

Conversation

rohitgr7
Copy link
Contributor

@rohitgr7 rohitgr7 commented Sep 9, 2021

What does this PR do?

Fixes #9404
TODO: need to merge/add similar tests for datamodule and callbacks in another PR.

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@rohitgr7 rohitgr7 added bug Something isn't working checkpointing Related to checkpointing labels Sep 11, 2021
@rohitgr7 rohitgr7 changed the title Restoring training state during fit only Fixed restoring training state during trainer.fit only Sep 11, 2021
@rohitgr7 rohitgr7 changed the title Fixed restoring training state during trainer.fit only Fix restoring training state during trainer.fit only Sep 11, 2021
@rohitgr7 rohitgr7 marked this pull request as ready for review September 11, 2021 17:22
@codecov
Copy link

codecov bot commented Sep 11, 2021

Codecov Report

Merging #9413 (dde4875) into master (3392215) will decrease coverage by 4%.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master   #9413    +/-   ##
=======================================
- Coverage      93%     89%    -4%     
=======================================
  Files         177     178     +1     
  Lines       15527   15597    +70     
=======================================
- Hits        14386   13821   -565     
- Misses       1141    1776   +635     

@rohitgr7 rohitgr7 requested a review from carmocca September 14, 2021 15:42
@mergify mergify bot removed the has conflicts label Sep 15, 2021
Copy link
Contributor

@carmocca carmocca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, some comments on the tests

@mergify mergify bot removed the has conflicts label Oct 1, 2021
@rohitgr7 rohitgr7 requested a review from ananthsub October 1, 2021 12:21
@mergify mergify bot added the has conflicts label Oct 1, 2021
@mergify mergify bot added ready PRs ready to be merged and removed has conflicts labels Oct 4, 2021
@rohitgr7 rohitgr7 requested a review from carmocca October 6, 2021 11:26
@rohitgr7 rohitgr7 enabled auto-merge (squash) October 6, 2021 14:47
@rohitgr7 rohitgr7 merged commit b303b4f into master Oct 6, 2021
@rohitgr7 rohitgr7 deleted the bugfix/rld_ckpt_on_fit branch October 6, 2021 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working checkpointing Related to checkpointing ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[checkpoint] Restoring training state doesn't check whether we're fitting
5 participants