Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep hidden state in the optimization loops #9368

Merged
merged 5 commits into from
Sep 8, 2021

Conversation

carmocca
Copy link
Contributor

@carmocca carmocca commented Sep 8, 2021

What does this PR do?

Part of #9349

Avoid saving the hidden state in the TrainingBatchLoop. This moves us one step closer to #8732

Does your PR introduce any breaking changes? If yes, please list them.

None

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • [n/a] Did you make sure to update the documentation with your changes? (if necessary)
  • [n/a] Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

@carmocca carmocca added this to the v1.5 milestone Sep 8, 2021
@carmocca carmocca self-assigned this Sep 8, 2021
@carmocca carmocca marked this pull request as ready for review September 8, 2021 01:26
@mergify mergify bot added the ready PRs ready to be merged label Sep 8, 2021
@mergify mergify bot requested a review from a team September 8, 2021 09:01
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@mergify mergify bot added the has conflicts label Sep 8, 2021
@carmocca carmocca enabled auto-merge (squash) September 8, 2021 13:09
@mergify mergify bot removed the has conflicts label Sep 8, 2021
@carmocca carmocca merged commit 8407238 into master Sep 8, 2021
@carmocca carmocca deleted the refactor/keep-hiddens-in-optim-loops branch September 8, 2021 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready PRs ready to be merged refactor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants