Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove redundant optimizer idx reset on epoch #9285

Merged
merged 2 commits into from
Sep 2, 2021

Conversation

awaelchli
Copy link
Contributor

@awaelchli awaelchli commented Sep 2, 2021

What does this PR do?

Follow up to comment by @carmocca. The reset of optimizer_idx at the end of a training epoch is redundant. It does not relate to the progress update.

Having this or not leaves no impact, it's just redundant.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

I made sure I had fun coding 🙃

@carmocca carmocca added this to the v1.5 milestone Sep 2, 2021
@awaelchli awaelchli marked this pull request as ready for review September 2, 2021 16:10
@mergify mergify bot added the ready PRs ready to be merged label Sep 2, 2021
@mergify mergify bot requested a review from a team September 2, 2021 16:10
@carmocca carmocca enabled auto-merge (squash) September 2, 2021 16:36
@carmocca carmocca merged commit 530caef into master Sep 2, 2021
@carmocca carmocca deleted the refactor/optim-progress-reset-epoch branch September 2, 2021 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready PRs ready to be merged refactor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants