Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete TrainingEpochLoop._dataloader_idx which always equals 0 #8911

Merged
merged 3 commits into from
Aug 16, 2021

Conversation

carmocca
Copy link
Contributor

What does this PR do?

See title.

A follow-up could deprecate the argument for on_train_batch_{start,end}.

Does your PR introduce any breaking changes? If yes, please list them.

None

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • [n/a] Did you make sure to update the documentation with your changes? (if necessary)
  • [n/a] Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • [n/a] Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

@carmocca carmocca added this to the v1.5 milestone Aug 14, 2021
@carmocca carmocca self-assigned this Aug 14, 2021
@codecov
Copy link

codecov bot commented Aug 14, 2021

Codecov Report

Merging #8911 (e3c3cc5) into master (0aa5cc7) will decrease coverage by 0%.
The diff coverage is 100%.

@@          Coverage Diff           @@
##           master   #8911   +/-   ##
======================================
- Coverage      93%     93%   -0%     
======================================
  Files         172     172           
  Lines       14114   14111    -3     
======================================
- Hits        13094   13091    -3     
  Misses       1020    1020           

@carmocca carmocca marked this pull request as ready for review August 14, 2021 14:17
@mergify mergify bot added the ready PRs ready to be merged label Aug 14, 2021
@carmocca carmocca merged commit d0efb55 into master Aug 16, 2021
@carmocca carmocca deleted the refactor/delete-tr-epoch-dl-idx branch August 16, 2021 11:34
four4fish pushed a commit to four4fish/pytorch-lightning that referenced this pull request Aug 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready PRs ready to be merged refactor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants