remove deprecated args to learning rate step function #890
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting
What does this PR do?
Fixes #708.
Removing of the deprecated
epoch
argument in the.step(...)
method of learning rate schedulers. Currently (pytorch 1.4) if the user give aepoch
argument, anDeprecationWarning
will be thrown. But looking at the pytorch master branch, the warning has been changed toUserWarning
meaning that in the future, if theepoch
argument is not removed, this will give an warning each time a model with a learning rate scheduler is trained.PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.