-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix recursive call for apply_to_collection(include_none=False)
#8719
Conversation
Codecov Report
@@ Coverage Diff @@
## master #8719 +/- ##
=======================================
- Coverage 93% 89% -4%
=======================================
Files 169 169
Lines 14075 14552 +477
=======================================
- Hits 13045 12890 -155
- Misses 1030 1662 +632 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks for the fix @awaelchli
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks for the fix @awaelchli
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great catch !
(cherry picked from commit 963c267)
(cherry picked from commit 963c267)
What does this PR do?
The argument
include_none
was not passed down in the recursive call.The added test fails on master.
Note, the only place where this is currently used is the Result object.
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
I made sure I had fun coding 🙃