Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix recursive call for apply_to_collection(include_none=False) #8719

Merged
merged 3 commits into from
Aug 4, 2021

Conversation

awaelchli
Copy link
Contributor

@awaelchli awaelchli commented Aug 4, 2021

What does this PR do?

The argument include_none was not passed down in the recursive call.
The added test fails on master.

Note, the only place where this is currently used is the Result object.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

I made sure I had fun coding 🙃

@awaelchli awaelchli added this to the v1.4.x milestone Aug 4, 2021
@awaelchli awaelchli added the bug Something isn't working label Aug 4, 2021
@codecov
Copy link

codecov bot commented Aug 4, 2021

Codecov Report

Merging #8719 (4383000) into master (49df107) will decrease coverage by 4%.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master   #8719    +/-   ##
=======================================
- Coverage      93%     89%    -4%     
=======================================
  Files         169     169            
  Lines       14075   14552   +477     
=======================================
- Hits        13045   12890   -155     
- Misses       1030    1662   +632     

Copy link
Contributor Author

@awaelchli awaelchli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks for the fix @awaelchli

@awaelchli awaelchli marked this pull request as ready for review August 4, 2021 15:46
Copy link
Contributor

@carmocca carmocca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks for the fix @awaelchli

@mergify mergify bot added the ready PRs ready to be merged label Aug 4, 2021
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch !

@tchaton tchaton merged commit 963c267 into master Aug 4, 2021
@tchaton tchaton deleted the bugfix/include-none branch August 4, 2021 18:31
edward-io pushed a commit to edward-io/pytorch-lightning that referenced this pull request Aug 4, 2021
SeanNaren pushed a commit that referenced this pull request Aug 10, 2021
lexierule pushed a commit that referenced this pull request Aug 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants