Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update training_epoch_loop.py #8594

Closed
wants to merge 2 commits into from
Closed

Update training_epoch_loop.py #8594

wants to merge 2 commits into from

Conversation

MirMustafaAli
Copy link

@MirMustafaAli MirMustafaAli commented Jul 28, 2021

pass total_batch_idx for validation check as parameter

What does this PR do?

Fixes #8135

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

MirMustafaAli and others added 2 commits July 28, 2021 02:21
@codecov
Copy link

codecov bot commented Jul 29, 2021

Codecov Report

Merging #8594 (e7b7739) into master (df16713) will decrease coverage by 48%.
The diff coverage is 0%.

@@           Coverage Diff            @@
##           master   #8594     +/-   ##
========================================
- Coverage      92%     45%    -48%     
========================================
  Files         218     218             
  Lines       14398   14396      -2     
========================================
- Hits        13296    6450   -6846     
- Misses       1102    7946   +6844     

@stale
Copy link

stale bot commented Aug 12, 2021

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. If you need further help see our docs: https://pytorch-lightning.readthedocs.io/en/latest/generated/CONTRIBUTING.html#pull-request or ask the assistance of a core contributor here or on Slack. Thank you for your contributions.

@stale stale bot added the won't fix This will not be worked on label Aug 12, 2021
@stale
Copy link

stale bot commented Aug 18, 2021

This pull request is going to be closed. Please feel free to reopen it create a new from the actual master.

@stale stale bot closed this Aug 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
won't fix This will not be worked on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extend val_check_interval support
1 participant