Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix restoring finetune callbacks after accelerator setup on training resume #8501

Merged
merged 20 commits into from
Jul 23, 2021

Conversation

eladsegal
Copy link
Contributor

@eladsegal eladsegal commented Jul 21, 2021

What does this PR do?

Fixes #8502

Does your PR introduce any breaking changes ? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)
  • Did you list all the breaking changes introduced by this pull request?

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@pep8speaks
Copy link

pep8speaks commented Jul 21, 2021

Hello @eladsegal! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2021-07-23 07:51:20 UTC

@eladsegal eladsegal changed the title [draft] restore callbacks after accelerator setup on training resume [Draft for tests, no need to review yet] restore callbacks after accelerator setup on training resume Jul 21, 2021
@codecov
Copy link

codecov bot commented Jul 21, 2021

Codecov Report

Merging #8501 (5b09601) into master (0ad7f3a) will decrease coverage by 4%.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master   #8501    +/-   ##
=======================================
- Coverage      92%     88%    -4%     
=======================================
  Files         218     218            
  Lines       14390   14401    +11     
=======================================
- Hits        13278   12681   -597     
- Misses       1112    1720   +608     

@mergify mergify bot removed the has conflicts label Jul 21, 2021
@tchaton
Copy link
Contributor

tchaton commented Jul 21, 2021

Dear @eladsegal ,

I have added a test on your branch and some minor fixes. Mind giving it a try to see if it fixes your problem ?

Best,
T.C

@tchaton tchaton self-assigned this Jul 21, 2021
@tchaton tchaton added the bug Something isn't working label Jul 21, 2021
@tchaton tchaton added this to the v1.4 milestone Jul 21, 2021
@Borda Borda marked this pull request as draft July 21, 2021 13:31
@Borda Borda changed the title [Draft for tests, no need to review yet] restore callbacks after accelerator setup on training resume restore callbacks after accelerator setup on training resume Jul 21, 2021
@eladsegal
Copy link
Contributor Author

Dear @eladsegal ,

I have added a test on your branch and some minor fixes. Mind giving it a try to see if it fixes your problem ?

Best,
T.C

Thank you! I was planning on finalizing the pull request, but you were too quick :)
It does solve my problem

@tchaton tchaton marked this pull request as ready for review July 21, 2021 16:05
@mergify mergify bot removed the has conflicts label Jul 21, 2021
@awaelchli
Copy link
Contributor

I'm changing the title of this PR to reflect that this is about the finetuning callback implementation :) 😇

Copy link
Contributor

@awaelchli awaelchli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall
thanks @eladsegal and @tchaton for taking care of my negligence in #7652, I have not paid enough attention and should have seen that it breaks

@mergify mergify bot removed the has conflicts label Jul 22, 2021
@mergify mergify bot added the ready PRs ready to be merged label Jul 22, 2021
@Borda Borda mentioned this pull request Jul 22, 2021
12 tasks
@awaelchli awaelchli enabled auto-merge (squash) July 22, 2021 20:02
@mergify mergify bot removed the has conflicts label Jul 23, 2021
@awaelchli awaelchli merged commit 07635d0 into Lightning-AI:master Jul 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working callback ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Resuming training from checkpoint doesn't work correctly with BaseFinetuning
6 participants