-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix restoring finetune callbacks after accelerator setup on training resume #8501
Conversation
Hello @eladsegal! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2021-07-23 07:51:20 UTC |
Codecov Report
@@ Coverage Diff @@
## master #8501 +/- ##
=======================================
- Coverage 92% 88% -4%
=======================================
Files 218 218
Lines 14390 14401 +11
=======================================
- Hits 13278 12681 -597
- Misses 1112 1720 +608 |
Dear @eladsegal , I have added a test on your branch and some minor fixes. Mind giving it a try to see if it fixes your problem ? Best, |
Thank you! I was planning on finalizing the pull request, but you were too quick :) |
I'm changing the title of this PR to reflect that this is about the finetuning callback implementation :) 😇 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM overall
thanks @eladsegal and @tchaton for taking care of my negligence in #7652, I have not paid enough attention and should have seen that it breaks
What does this PR do?
Fixes #8502
Does your PR introduce any breaking changes ? If yes, please list them.
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃