Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wip] [Feat] Add DataLoader state_dict to Loop #8465

Closed
wants to merge 39 commits into from
Closed

Conversation

tchaton
Copy link
Contributor

@tchaton tchaton commented Jul 19, 2021

What does this PR do?

Fixes #<issue_number>

Does your PR introduce any breaking changes ? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)
  • Did you list all the breaking changes introduced by this pull request?

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@stale
Copy link

stale bot commented Aug 2, 2021

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. If you need further help see our docs: https://pytorch-lightning.readthedocs.io/en/latest/generated/CONTRIBUTING.html#pull-request or ask the assistance of a core contributor here or on Slack. Thank you for your contributions.

@stale stale bot added the won't fix This will not be worked on label Aug 2, 2021
@awaelchli awaelchli added this to the v1.5 milestone Aug 2, 2021
@stale stale bot removed the won't fix This will not be worked on label Aug 2, 2021
@awaelchli awaelchli changed the title [Feat] Add DataLoader state_dict to Loop [wip] [Feat] Add DataLoader state_dict to Loop Aug 2, 2021
@mergify mergify bot removed the has conflicts label Aug 5, 2021
@awaelchli awaelchli closed this Aug 27, 2021
@awaelchli awaelchli deleted the loop_state_dict branch August 27, 2021 11:30
@awaelchli
Copy link
Contributor

completed in #8950

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants